Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added preloader. #436

Closed
wants to merge 1 commit into from
Closed

Added preloader. #436

wants to merge 1 commit into from

Conversation

happyrao78
Copy link

#412 Solved.

Copy link

vercel bot commented Jul 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
style-share ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 14, 2024 8:38am

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@@ -3,10 +3,13 @@ import ReactDOM from 'react-dom/client'
import App from './App.tsx'
import { RecoilRoot } from "recoil";
import './index.css'
// import PreLoader from './components/Loader/Loader';
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove commented code

// import axios from "axios";
// axios.defaults.baseURL = "http://localhost:3001/";

function App() {
const { theme, toggleTheme } = useTheme();
const { loading, isBlocked } = userBlock(5);
const [Preloading,setLoading]= useState(true);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const [Preloading,setLoading]= useState(true);
const [preLoading,setPreLoading]= useState(true);

Variable is not in react naming convention
Similar to https://react.dev/reference/react/useState#setstate

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great, just have one suggestion: instead of alternating between white and black colors in the preloader we can first show white then show black bg, and stop there.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As animation have also been added to the incoming text so that would not look good ,i tried it out. It just looks like a glitch.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok then we can go ahead with this

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do the changes stated above rest is good

Copy link
Owner

@VaibhavArora314 VaibhavArora314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove bun.lockb file and do above stated changes

@VaibhavArora314
Copy link
Owner

@happyrao78 any updates?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants